Fix keypress bug #27
Open
Fix keypress bug #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug around detecting which key was pressed in order to switch between javascript and coffeescript modes, allowing any keypress to scroll down the page. This commit opts to compare key strings on keyup to toggle only on a match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love this book! Lots of hard-won knowledge in there.
There's a bug around detecting which key was pressed in order to switch between language modes — currently any keypress will evaluate to false on this conditional, so space-bar-ing down the page is a little fraught.
This change plucks out the letter on keyup and only performs the toggle when the switch key is pressed. Also updates the
.ruby-versionsince it looks like that was only bumped in the Gemfile.